CODE: https://github.com/EQMacEmu/Server/pull/469 Cavedude: * Added rule CharacterisableAAs to disable AAs at the AAAction handle. * Finished the implementation of Disciplines I started in 0171eb9 * Discs are now treated as spells by the server code, but not the client. The server will use the effects in the spell data for each discipline. The animation, damage, and action packets are not sent when a discipline is cast, so the client is not aware that a spell has even been cast. It will use the normal discipline packet for the client side effects. * This commit includes a required SQL that contains all of the discipline spell data. The data was pulled from the PEQ database, but most of the spells have been heavily altered so their functionality matches our era instead of how Live exists currently. Despite this, exact percentages and magic numbers from our time were really hard to come by, so in many cases they were guessed at. The data may need to be tweaked as it is play tested. With this new system, these tweaks and changes can be done in the database. There shouldn't be a need to change the server code. * A new effect formula (150) was added to support the resitant discipline. * The discbonuses code was removed, as it is no longer needed. Disciplines now use spellbonuses like normal spells do. * Finished adding the discipline cast strings, and altered the framework to support the spell system as well as fix some bugs found along the way. * The following changes came about while testing discs: - Added missing resist bonuses for Beastlord and Monk. - While adding the new formula, the existing spell formula handles were cleaned up. Ones our spells don't use were removed, and a few missing ones were added. - Changed the order of the resists and stats in #showstats, so they match the order they appear in the client. Removed the heroic stats from there as well. - If #showstats 1 is typed, a shorter version of stats will now display with only core stats listed. Using this on a NPC has the same output as #npcstats. * Jolt type spells will now cause aggro. This is accomplished by using a second hate variable that holds our actual hate value, while the normal hate value remains 1. Once the second hate value reaches 0, hate will again be added directly to the normal hate variable. This new variable is only active when a Jolt spell has been used. All other attacks will use the normal hate variable as always. * Temporary bonuses to hate (due to proximity, health, sitting, etc) are still applied as normal. * Fixed the begging struct, which corrects desyncs, an always present fail message, and lack of coin updates. Also added some critical message and success messages as well as the possibility of getting more coin. * Bind Wound will no longer have a chance to skillup on failure. The message telling yourself to stand still has also been removed. * Changed some innate language skill levels to match data found on the forums. * Corrected an item desync caused by the server and client disagreeing on which slot to delete small throwing items from. * Speed buff spells (Sow) will no longer overwrite speed buff songs (Selo's) server side. * Fixed many issues with Pick Pockets. Corrected the packet struct, so coin updates, success messages display properly, and there is no chance of desyncs. * Changed the chance roll to be more uniform as pick pockets is leveled. * Critical failures now use player skill as part of its roll. * Improved the logic of how items and coin are chosen to steal. Many miscellaneous bugs were fixed. * Reduced the Pick Pockets skillup rate a small amount. * Adding some missing messages. * Looting your own corpse will no longer create "You have looted" messages. * Increased the swimming skillup rate a good amount. * NPCs will no longer turn and face the player while trading or opening a vendor window. This fixes quest sneaking, and hopefully vendor sneaking as well. * MerchantCloseShop() will now send OP_ShopEndConfirm which closes the vendor window and prevents the clients from desyncing. This affects the lua method and command. * Merchants will now also send OP_ShopEndConfirm to players they were interacting with when they begin to path. This also prevents a desync. (When a player moves, the window closes properly and it does not desync - the client must handle that case internally.) * Pets will no longer send the non-melee message from damage shields to their masters. * Players will now always receive a message when /consent fails or succeeds. (Both players will see the message on success.) * /consent can be now be done on other characters on the same account. * /consent now persists over zoning. * /consent will remain active for 20-30 minutes after the consenting player logs off. This timer can be adjusted as needed. If the consented players are still in-game, they will receive a message when the consent is denied. * Added multiplier_min to loottable_entries which allows developers to force the multiplier to 100% for the specified number of rolls. * AE spells and songs will no longer generate the "did not take hold" messages when a non-attackable player is in range. The affected player will continue to receive the protected message, however. * Fixed an arrow item desync where the client and server disagree on th…e range check, and one allows the arrow to shoot while the other does not. * Increased the archery range a bit, to better sync up with the client's range. * Texture will now be counted towards faction while using an elemental illusion spell, and gender will be counted when using a wolf illusion spell. * NPCs that do not have a quest, or don't have a trade event within their quest will now have their handins completely handled by the server code. * The NPC:ReturnNonQuestItems rule will determine if those NPCs will return items, or add them to their inventory. The default setting of true hands these items back to the player. * No drop items or any item that the NPC already has will be destroyed upon handing it in, if the handin is handled by the server code. If it is handled by Lua, then those items will be destroyed on the death of the NPC, before the item packets are created. Summoned pets are an exception to this, and can be given duplicate items. GM handins are completely exempt. * We are now marking items handed to a pet in their inventory. * Added #logs quiet which disables all gmsay logging until either the zone resets, or a log is manually enabled/all are reloaded. * Exported CanTalk() to Lua, which allows Lua scripts to check if the NPC is a race that should be able to speak a language. * NPCs on a roambox will now pause when hailed. * Added a quest item limit when adding items to a NPC's lootable. * Added PTimers logsys category, and removed the DEBUG_PTIMERS define. SQL is handled by world. * Heading will now be properly adjusted when using the portal in Paineel near the Shadowknight guild most of the time. * Consolidated Harm Touch and Lay on Hands to both use one ptimer, instead of both having two. This should eliminate client/server syncing problems and also fix the Fervent Blessing and Touch of the Wicked AAs. * Harm Touch and Lay in Hands will both have their timers reset on death. Haynar: * Fixed an issue which would cause 3 position update packets in a row, when leaving a grid waypoint. * Updated numeric messages for world request response returns. * Corrected SpawnPositionUpdate_Struct for position deltas (removed padding). * Added calculations for converting incoming and outgoing delta's. * IP Exemption checks changed to be against chars in zone or zoning. This will make it friendlier if you crash getting to the character select screen. DATABASE: Robregen * increase the spawn timer to 28 minutes for Lord Bergurgle/Ph * Lord Gimblox should now drop his ring 100% of the time. * Fairy Guards in Lesser Faydark should now only drop 1 power of earth at a time. * replace the roambox with Grids on an_azarak in Plane of Sky to eliminate the chance for them to fall below the island. * Upped the spawntimer to approximately 19 minutes in all mobs in Najena except Akksstaff * Added missing Epic NPC in the classic world. Check Dev notes to see which is updated (Green). * updated Solusek Ro NPC with the correct faction. Torven * airplane: Spiroc Lord phantom sword graphic removed. * airplane: Evil Eye NPCs will now dispel more often. * soldungb: Lord Nagafen and Lady Vox given increased atk values. * fearplane: Zone now flagged self bindable. * fearplane: Resist adjust removed from Terror's AoE. Terror's AC increased. * kedge: Swirlspine seahorse assist radius temporarily increased until pathing is fixed. * hateplane: Maestro respawn timer reduced to 12 hours. * Maestro and fearplane golems now using new multiplier minimum field in loot tables. SCRIPT: Robregen * Fixed the script for Cleric Epic Shmendrik_Lavawalker/Natasha_Whitewater/spirit_of_flame * Most Epic scripts has been updated in the classic world. Check Dev notes to see which is updated (Green).
