Allaclone pull requests still desired?

Discussion in 'General Discussion' started by Palarran, Oct 10, 2020.

  1. Palarran

    Palarran Well-Known Member

    Messages:
    154
    I don't have it in me to do a full revamp, but I could possibly submit a few minor bug fixes and improvements.

    Some things I have in mind, off the top of my head:
    * Displaying the correct required level to proc on weapons
    * Displaying actual best-case NPC selll/buy prices, taking into account the cost multiplier on certain items when buying from an NPC
    * Cleaning up the item search form, removing out-of-era options and making sure everything works ("Include No Drop" doesn't do what I expect, for instance)
    * Moving item sources to a separate page so that item stats can be displayed faster (much of the time when I click an item link I only want to see its stats)
    * Displaying merchant NPC locations

    This thread is 5 years old, but suggests pull requests would be welcome, and that everything I need to implement them can be found there:
    https://www.takproject.net/forums/i...en-searching-by-resist-stats.4301/#post-24158

    Is that still accurate? Does github still reflect the current state of allaclone, and has the database schema changed since the linked "monthly dump" (which also appears to be about 5 years old)?
     
    John Stark likes this.
  2. Mokli

    Mokli I Feel Loved

    Messages:
    2,458
    It would be awesome to get it fixed up. One thing that also has annoyed me is that Beneficial spell haste displays as detrimental. When I looked at this, it was because they share the same ID, yet different description, so its an issue with the parser.

    Example:
    https://www.takproject.net/allaclone/spell.php?id=3125
    vs
    http://lucy.alkabor.com/spell_3125.html

    Allaclone also doesn't display the specific resist that spells are hitting, yet will show the resist adjustment amount:
    https://www.takproject.net/allaclone/spell.php?id=856
     
    Last edited: Oct 10, 2020
  3. Break

    Break People Like Me

    Messages:
    615
    1) I noticed that you cannot search Allaclone for items with negative resists. The list that comes back seems random. I was attempting to compile a list of enchanter charm gear for pets.
    2) Being able to search for specific instrument modifiers would be great too.
     
  4. Lenas

    Lenas I Feel Loved

    Messages:
    2,968
    No, there is a private TAKP Allaclone branch. I made some updates 3 months ago but I can't deploy because my SSH user wont connect. @Speedz holds the keys to the castle here.

    Yes, you'll see a number of errors.
     
  5. Speedz

    Speedz Administrator Staff Member

    Messages:
    2,469
    To make it clear, not holding anything back on purpose.
    Been dealing with lots RL and we have to set Lenas back up in the ssh again.
    We'll get there, just only so much can be done at one time :)
     
    Mokli and Cadsuane like this.